Re: [PATCH v3 2/2] ALSA: hda/realtek: Add mute LED and micmute LED support for HP systems

From: Kai-Heng Feng
Date: Wed Jun 17 2020 - 11:25:22 EST




> On Jun 17, 2020, at 19:55, Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> On Wed, 17 Jun 2020 12:29:02 +0200,
> Kai-Heng Feng wrote:
>>
>> There are two more HP systems control mute LED from HDA codec and need
>> to expose micmute led class so SoF can control micmute LED.
>>
>> Add quirks to support them.
>>
>> Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
>
> I guess this can be applied independently from the patch#1?
> If so, I'll queue this for for-linus branch.

Yes please. Thanks!

Kai-Heng

>
>
> thanks,
>
> Takashi
>
>
>> ---
>> v3:
>> - No change.
>> v2:
>> - Wording.
>>
>> sound/pci/hda/patch_realtek.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 0587d1e96b19..cd1a3619806a 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -7473,6 +7473,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> SND_PCI_QUIRK(0x103c, 0x83b9, "HP Spectre x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> SND_PCI_QUIRK(0x103c, 0x8497, "HP Envy x360", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> SND_PCI_QUIRK(0x103c, 0x84e7, "HP Pavilion 15", ALC269_FIXUP_HP_MUTE_LED_MIC3),
>> + SND_PCI_QUIRK(0x103c, 0x869d, "HP", ALC236_FIXUP_HP_MUTE_LED),
>> + SND_PCI_QUIRK(0x103c, 0x8729, "HP", ALC285_FIXUP_HP_GPIO_LED),
>> SND_PCI_QUIRK(0x103c, 0x8736, "HP", ALC285_FIXUP_HP_GPIO_LED),
>> SND_PCI_QUIRK(0x103c, 0x877a, "HP", ALC285_FIXUP_HP_MUTE_LED),
>> SND_PCI_QUIRK(0x103c, 0x877d, "HP", ALC236_FIXUP_HP_MUTE_LED),
>> --
>> 2.17.1
>>