Re: [PATCH v2 1/1] fs: move kernel_read_file* to its own include file

From: Greg Kroah-Hartman
Date: Wed Jun 17 2020 - 11:36:49 EST


On Wed, Jun 17, 2020 at 08:17:10AM -0700, Scott Branden wrote:
> Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h
> include file. That header gets pulled in just about everywhere
> and doesn't really need functions not related to the general fs interface.
>
> Suggested-by: Christoph Hellwig <hch@xxxxxx>
> Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> ---
> drivers/base/firmware_loader/main.c | 1 +
> fs/exec.c | 1 +
> include/linux/fs.h | 39 ----------------------
> include/linux/ima.h | 1 +
> include/linux/kernel_read_file.h | 52 +++++++++++++++++++++++++++++
> include/linux/security.h | 1 +
> kernel/kexec_file.c | 1 +
> kernel/module.c | 1 +
> security/integrity/digsig.c | 1 +
> security/integrity/ima/ima_fs.c | 1 +
> security/integrity/ima/ima_main.c | 1 +
> security/integrity/ima/ima_policy.c | 1 +
> security/loadpin/loadpin.c | 1 +
> security/security.c | 1 +
> security/selinux/hooks.c | 1 +
> 15 files changed, 65 insertions(+), 39 deletions(-)
> create mode 100644 include/linux/kernel_read_file.h

What changed from v1? Always put that below the --- line.

thanks,

greg k-h