Re: [PATCH net-next v2 6/8] net: phy: mscc: timestamping and PHC support

From: Jakub Kicinski
Date: Wed Jun 17 2020 - 12:32:22 EST


On Wed, 17 Jun 2020 15:31:25 +0200 Antoine Tenart wrote:
> This patch adds support for PHC and timestamping operations for the MSCC
> PHY. PTP 1-step and 2-step modes are supported, over Ethernet and UDP.
>
> To get and set the PHC time, a GPIO has to be used and changes are only
> retrieved or committed when on a rising edge. The same GPIO is shared by
> all PHYs, so the granularity of the lock protecting it has to be
> different from the ones protecting the 1588 registers (the VSC8584 PHY
> has 2 1588 blocks, and a single load/save pin).
>
> Co-developed-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
> Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx>
> Signed-off-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>

drivers/net/phy/mscc/mscc_ptp.c:406:24: warning: restricted __be16 degrades to integer
drivers/net/phy/mscc/mscc_ptp.c:407:24: warning: restricted __be16 degrades to integer
drivers/net/phy/mscc/mscc_ptp.c:1213:23: warning: symbol 'vsc85xx_clk_caps' was not declared. Should it be static?

Please make sure you don't add warnings when built with W=1 C=1 flags.