Re: [PATCH] crypto: sa2ul: fix odd_ptr_err.cocci warnings

[Tero Kristo]

On 18/06/2020 10:28, Herbert Xu wrote:
> On Fri, Jun 12, 2020 at 11:22:02PM +0200, Julia Lawall wrote:
> > From: kernel test robot <lkp@xxxxxxxxx>
> >
> > PTR_ERR should normally access the value just tested by IS_ERR
> >
> > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> >
> > Fixes: 5b8516f3bedb ("crypto: sa2ul: Add crypto driver")
> > CC: Keerthy <j-keerthy@xxxxxx>
> > Signed-off-by: kernel test robot <lkp@xxxxxxxxx>
> > Signed-off-by: Julia Lawall <julia.lawall@xxxxxxxx>
> > ---
> >
> > tree:   git://git.ti.com/ti-linux-kernel/ti-linux-kernel.git ti-linux-5.4.y
> > head:   134a1b1f8814115e2dd115b67082321bf9e63cc1
> > commit: 5b8516f3bedb3e1c273e7747b6e4a85c6e47907a [2369/7050] crypto: sa2ul: Add crypto driver
> > :::::: branch date: 3 hours ago
> > :::::: commit date: 5 months ago
> >
> >   sa2ul.c |    4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
>
> This driver does not exist in the cryptodev tree.

Yeah, this is old codebase which only exist in TI internal tree at the 
moment, the driver posted upstream has seen considerable evolution (and 
is under review atm.)

-Tero
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki