Re: [PATCH] crypto: caam/qi2: remove redundant assignment to ret
From: Herbert Xu
Date: Thu Jun 18 2020 - 07:01:19 EST
On Thu, Jun 18, 2020 at 01:54:55PM +0300, Horia GeantÄ wrote:
>
> The proper fix would be updating the ahash_finup_no_ctx() function
> to return the specific error code:
> return ret;
> instead of returning -ENOMEM for all error cases.
>
> For example error code returned by dpaa2_caam_enqueue()
> should be returned instead of -ENOMEM.
You can do that as a follow-up. The patch is correct as is.
Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt