Re: [PATCH v2] coccinelle: misc: add array_size_dup script to detect missed overflow checks

[Markus Elfring]

Why did you repeat a typo from the previous patch subject?


> Changes in v2:
â
> - assignment operator used

Did you add just a metavariable for this implementation detail?


â
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;

How do you think about to use the following SmPL code variant?

expression subE1 <= as.E1, subE2 <= as.E2, as.E1, as.E2, E3;


> +      when != \(&E1\|&E2\|&subE1\|&subE2\)

I suggest to move the ampersand before the disjunction in such
SmPL code exclusion specifications.

+      when != & \(E1 \| E2 \| subE1 \| subE2\)


> +coccilib.report.print_report(p2[0],
> +f"WARNING: array_size is already used (line {p1[0].line}) to compute \
> +the same size")

I would prefer an other code formatting at such places.

+coccilib.report.print_report(p2[0],
+                             f"WARNING: array_size is already used (line {p1[0].line}) to compute the same size.")


Regards,
Markus