Re: [PATCH v2] RDMA/rvt: Fix potential memory leak caused by rvt_alloc_rq

From: Jason Gunthorpe
Date: Thu Jun 18 2020 - 08:45:33 EST


On Sat, Jun 13, 2020 at 11:11:48PM -0500, Aditya Pakki wrote:
> In case of failure of alloc_ud_wq_attr(), the memory allocated by
> rvt_alloc_rq() is not freed. Fix it by calling rvt_free_rq() using
> the existing clean-up code.
>
> Fixes: d310c4bf8aea ("IB/{rdmavt, hfi1, qib}: Remove AH refcount for UD QPs")
> Signed-off-by: Aditya Pakki <pakki001@xxxxxxx>
> Acked-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
> ---
> v1: Fix incorrect order of rvt_free_rq and free_ud_wq_attr.
> Suggested by Dennis Dalessandro.
> ---
> drivers/infiniband/sw/rdmavt/qp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)

Applied to for-rc, thanks

Jason