Re: [PATCH v4] perf tools: Check libasan and libubsan in Makefile.config

From: Arnaldo Carvalho de Melo
Date: Thu Jun 18 2020 - 09:30:05 EST


Em Thu, Jun 18, 2020 at 02:57:46PM +0200, Jiri Olsa escreveu:
> On Thu, Jun 18, 2020 at 10:06:01AM +0800, Tiezhu Yang wrote:
> > When build perf with ASan or UBSan, if libasan or libubsan can not find,
> > the feature-glibc is 0 and there exists the following error log which is
> > wrong, because we can find gnu/libc-version.h in /usr/include, glibc-devel
> > is also installed.
> >
> > [yangtiezhu@linux perf]$ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address'

<SNIP>

> > After install libasan and libubsan, the feature-glibc is 1 and the build
> > process is success, so the cause is related with libasan or libubsan, we
> > should check them and print an error log to reflect the reality.

> > Signed-off-by: Tiezhu Yang <yangtiezhu@xxxxxxxxxxx>
> > ---
> >
> > v2:
> > - Check libasan and libubsan in tools/build/Makefile.feature
> > - Modify the patch subject

> Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>

Applied after changing the subject to:

[PATCH] perf build: Fix error message when asking for -fsanitize=address without required libraries

Will test now.

- Arnaldo