Re: [PATCH] [perf] sort : Fix null pointer dereference in _hist_entry__sym_snprintf

[Andi Kleen]

> diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> index d42339df20f8..25c7c96893f6 100644
> --- a/tools/perf/util/sort.c
> +++ b/tools/perf/util/sort.c
> @@ -294,6 +294,9 @@ static int _hist_entry__sym_snprintf(struct map_symbol *ms,
>  				     u64 ip, char level, char *bf, size_t size,
>  				     unsigned int width)
>  {
> +	if (!ms) 
> +		return 0;
> +
>  	struct symbol *sym = ms->sym;
>  	struct map *map = ms->map;
>  	size_t ret = 0;

This should have given warnings because Linux and perf coding style
forbids fixed statement/declarations.

Also what's the backtrace where it is NULL? Perhaps better to fix it in
the caller.

-Andi