Re: [PATCH v4 1/5] spi: spi-geni-qcom: No need for irqsave variant of spinlock calls
From: Mark Brown
Date: Thu Jun 18 2020 - 11:15:48 EST
On Thu, Jun 18, 2020 at 08:06:22AM -0700, Douglas Anderson wrote:
> The driver locks its locks in two places.
>
> In the first usage of the lock the function doing the locking already
> has a sleeping call and thus we know we can't be called from interrupt
> context. That means we can use the "spin_lock_irq" variant of the
> function.
Please do not submit new versions of already applied patches, please
submit incremental updates to the existing code. Modifying existing
commits creates problems for other users building on top of those
commits so it's best practice to only change pubished git commits if
absolutely essential.
Attachment:
signature.asc
Description: PGP signature