RE: [PATCH 1/8] Drivers: hv: vmbus: Remove the target_vp field from the vmbus_channel struct

From: Michael Kelley
Date: Thu Jun 18 2020 - 11:24:15 EST


From: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx> Sent: Wednesday, June 17, 2020 9:47 AM
>
> The field is read only in __vmbus_open() and it is already stored twice
> (after a call to hv_cpu_number_to_vp_number()) in target_cpu_store() and
> init_vp_index(); there is no need to "cache" its value in the channel
> data structure.
>
> Suggested-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx>
> ---
> drivers/hv/channel.c | 3 ++-
> drivers/hv/channel_mgmt.c | 3 ---
> drivers/hv/vmbus_drv.c | 2 --
> include/linux/hyperv.h | 15 +++++++--------
> 4 files changed, 9 insertions(+), 14 deletions(-)

Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>