RE: [PATCH 7/8] scsi: storvsc: Introduce the per-storvsc_device spinlock
From: Michael Kelley
Date: Thu Jun 18 2020 - 14:34:45 EST
From: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx> Sent: Wednesday, June 17, 2020 9:47 AM
>
> storvsc uses the spinlock of the hv_device's primary channel to
> serialize modifications of stor_chns[] performed by storvsc_do_io()
> and storvsc_change_target_cpu(), when it could/should use a (per-)
> storvsc_device spinlock: this change untangles the synchronization
> mechanism for the (storvsc-specific) stor_chns[] array from the
> "generic" VMBus code and data structures, clarifying the scope of
> this synchronization mechanism.
>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx>
> ---
> drivers/scsi/storvsc_drv.c | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
FWIW, this patch will need to get routed to the SCSI maintainers and go through
the SCSI tree.
Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>