RE: [PATCH 8/8] Drivers: hv: vmbus: Remove the lock field from the vmbus_channel struct
From: Michael Kelley
Date: Thu Jun 18 2020 - 14:35:54 EST
From: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx> Sent: Wednesday, June 17, 2020 9:47 AM
>
> The spinlock is (now) *not used to protect test-and-set accesses
> to attributes of the structure or sc_list operations.
>
> There is, AFAICT, a distinct lack of {WRITE,READ}_ONCE()s in the
> handling of channel->state, but the changes below do not seem to
> make things "worse". ;-)
>
> Signed-off-by: Andrea Parri (Microsoft) <parri.andrea@xxxxxxxxx>
> ---
> drivers/hv/channel.c | 6 +-----
> drivers/hv/channel_mgmt.c | 1 -
> include/linux/hyperv.h | 6 ------
> 3 files changed, 1 insertion(+), 12 deletions(-)
>
Reviewed-by: Michael Kelley <mikelley@xxxxxxxxxxxxx>