Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs

From: Uladzislau Rezki
Date: Thu Jun 18 2020 - 17:17:45 EST


> > <snip>
> > trace_rcu_invoke_kfree_bulk_callback(
> > rcu_state.name, bkvhead[i]->nr_records,
> > bkvhead[i]->records);
> > if (i == 0)
> > kfree_bulk(bkvhead[i]->nr_records,
> > bkvhead[i]->records);
> > else
> > vfree_bulk(bkvhead[i]->nr_records,
> > bkvhead[i]->records);
> > <snip>
> >
> > Matthew, what is your thought?
>
> That was my thinking too. If we had a kvfree_bulk(), I would expect it to
> handle a mixture of vfree and kfree, but you've segregated them already.
> So I think this is better.
>
Yes, the segregation is done. Having vfree_bulk() is enough then.
We are on the same page :)

Thanks!

--
Vlad Rezki