Re: [PATCH] Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"

[Guenter Roeck]

On 6/19/20 12:47 AM, Christoph Hellwig wrote:
> On Fri, Jun 19, 2020 at 01:48:23PM +0900, Masahiro Yamada wrote:
>> This reverts commit e0b250b57dcf403529081e5898a9de717f96b76b.
>>
>> Now that "make install" copies modules.builtin to $(INSTALL_MOD_PATH),
>> it breaks systems that do not set INSTALL_MOD_PATH for "make install".
>>
>> While modules.builtin is useful for CONFIG_MODULES=n, this way gives
>> unexpected impact to existing systems. Maybe "make modules_install"
>> can install modules.builtin irrespective of CONFIG_MODULES as Jonas
>> originally suggested. Anyway, this commit should be reverted ASAP.
> 
> What is the "unexpected impact?  This commit log needs to explain
> that.
> 

$ make INSTALL_PATH=/tmp/destdir install
mkdir: cannot create directory â/lib/modules/5.8.0-rc1+/â: Permission denied
Makefile:1342: recipe for target '_builtin_inst_' failed
make: *** [_builtin_inst_] Error 1

Guenter