Re: [PATCH] coccinelle: api/kstrdup: fix coccinelle position

From: Markus Elfring
Date: Fri Jun 19 2020 - 11:46:24 EST

Next message: Greg Kroah-Hartman: "[PATCH 5.7 144/376] selinux: fix error return code in policydb_read()"
Previous message: Greg Kroah-Hartman: "[PATCH 5.7 191/376] crypto: blake2b - Fix clang optimization for ARMv7-M"
In reply to: Julia Lawall: "Re: [Cocci] [PATCH] coccinelle: api/kstrdup: fix coccinelle position"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

> There is a typo in rule r2. Position p1 should be attached to kzalloc() call.

I find such a suggestion reasonable for an implementation detail.

I would find an other patch subject clearer.

How do you think about to move the specification â@p1â out of SmPL disjunctions?

Regards,
Markus

Next message: Greg Kroah-Hartman: "[PATCH 5.7 144/376] selinux: fix error return code in policydb_read()"
Previous message: Greg Kroah-Hartman: "[PATCH 5.7 191/376] crypto: blake2b - Fix clang optimization for ARMv7-M"
In reply to: Julia Lawall: "Re: [Cocci] [PATCH] coccinelle: api/kstrdup: fix coccinelle position"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]