Re: [PATCH v2 2/2] xfs: Fix false positive lockdep warning with sb_internal & fs_reclaim

From: Waiman Long
Date: Fri Jun 19 2020 - 12:07:42 EST


On 6/19/20 9:21 AM, Christoph Hellwig wrote:
I find it really confusing that we record this in current->flags.
per-thread state makes total sense for not dipping into fs reclaim.
But for annotating something related to memory allocation passing flags
seems a lot more descriptive to me, as it is about particular locks.

I am dropping this patchset as just using PF_MEMALLOC_NOFS is good enough.

Cheers,
Longman