Re: mt7612 suspend/resume issue

From: Oleksandr Natalenko
Date: Fri Jun 19 2020 - 12:20:00 EST

Next message: Greg Kroah-Hartman: "[PATCH 4.19 201/267] PCI: Avoid FLR for AMD Starship USB 3.0"
Previous message: Greg Kroah-Hartman: "[PATCH 4.19 185/267] platform/x86: intel-hid: Add a quirk to support HP Spectre X2 (2015)"
In reply to: Lorenzo Bianconi: "Re: mt7612 suspend/resume issue"
Next in thread: Lorenzo Bianconi: "Re: mt7612 suspend/resume issue"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hello, Lorenzo.

Thanks for the quick reply. Please see my observation below.

On Thu, Jun 18, 2020 at 01:18:59PM +0200, Lorenzo Bianconi wrote:
> I have not reproduced the issue myself yet, but I guess we can try:
> 1- update to latest Felix's tree [1]
> 2- could you please try to apply the patch below? (compile-test only)

I've started with trying your patch first (apllied to v5.7.4). Please
see my comments on it inline.

> [1] https://github.com/nbd168/wireless
>
> From 400268a0ee5843cf736308504dfbd2f20a291eaf Mon Sep 17 00:00:00 2001
> Message-Id: <400268a0ee5843cf736308504dfbd2f20a291eaf.1592478809.git.lorenzo@xxxxxxxxxx>
> From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> Date: Thu, 18 Jun 2020 13:10:11 +0200
> Subject: [PATCH] mt76: mt76x2: fix pci suspend
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> ---
> .../net/wireless/mediatek/mt76/mt76x02_dma.h | 1 +
> .../net/wireless/mediatek/mt76/mt76x02_mmio.c | 15 +++++
> .../net/wireless/mediatek/mt76/mt76x2/pci.c | 58 +++++++++++++++++++
> 3 files changed, 74 insertions(+)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_dma.h b/drivers/net/wireless/mediatek/mt76/mt76x02_dma.h
> index 4aff4f8e87b6..6262f2ecded5 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_dma.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_dma.h
> @@ -62,5 +62,6 @@ mt76x02_wait_for_wpdma(struct mt76_dev *dev, int timeout)
> int mt76x02_dma_init(struct mt76x02_dev *dev);
> void mt76x02_dma_disable(struct mt76x02_dev *dev);
> void mt76x02_dma_cleanup(struct mt76x02_dev *dev);
> +void mt76x02_dma_reset(struct mt76x02_dev *dev);
>
> #endif /* __MT76x02_DMA_H */
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c b/drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c
> index cbbe986655fe..e2631c964331 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x02_mmio.c
> @@ -348,6 +348,21 @@ void mt76x02_dma_disable(struct mt76x02_dev *dev)
> }
> EXPORT_SYMBOL_GPL(mt76x02_dma_disable);
>
> +void mt76x02_dma_reset(struct mt76x02_dev *dev)
> +{
> + int i;
> +
> + mt76x02_dma_disable(dev);
> + usleep_range(1000, 2000);
> +
> + for (i = 0; i < __MT_TXQ_MAX; i++)
> + mt76_queue_tx_cleanup(dev, i, true);
> + mt76_for_each_q_rx(&dev->mt76, i)

Since v5.7.4 doesn't have this macro, I've pulled it manually.

> + mt76_queue_rx_reset(dev, i);
> +
> + mt76x02_dma_enable(dev);
> +}

I had to add EXPORT_SYMBOL_GPL(mt76x02_dma_reset) in order to get the
kernel linked successfully.

> +
> void mt76x02_mac_start(struct mt76x02_dev *dev)
> {
> mt76x02_mac_reset_counters(dev);
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> index 53ca0cedf026..5543e242fb9b 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x2/pci.c
> @@ -103,6 +103,60 @@ mt76pci_remove(struct pci_dev *pdev)
> mt76_free_device(mdev);
> }
>
> +static int __maybe_unused
> +mt76x2e_suspend(struct pci_dev *pdev, pm_message_t state)
> +{
> + struct mt76_dev *mdev = pci_get_drvdata(pdev);
> + struct mt76x02_dev *dev = container_of(mdev, struct mt76x02_dev, mt76);
> + int i, err;
> +
> + napi_disable(&mdev->tx_napi);
> + tasklet_kill(&mdev->pre_tbtt_tasklet);
> + tasklet_kill(&mdev->tx_tasklet);
> +
> + mt76_for_each_q_rx(mdev, i)
> + napi_disable(&mdev->napi[i]);
> +
> + mt76x02_dma_reset(dev);
> +
> + pci_enable_wake(pdev, pci_choose_state(pdev, state), true);
> + pci_save_state(pdev);
> + err = pci_set_power_state(pdev, pci_choose_state(pdev, state));
> + if (err)
> + goto restore;
> +
> + return 0;
> +
> +restore:
> + mt76_for_each_q_rx(mdev, i)
> + napi_enable(&mdev->napi[i]);
> + napi_enable(&mdev->tx_napi);
> +
> + return err;
> +}
> +
> +static int __maybe_unused
> +mt76x2e_resume(struct pci_dev *pdev)
> +{
> + struct mt76_dev *mdev = pci_get_drvdata(pdev);
> + int i, err;
> +
> + err = pci_set_power_state(pdev, PCI_D0);
> + if (err)
> + return err;
> +
> + pci_restore_state(pdev);
> +
> + mt76_for_each_q_rx(mdev, i) {
> + napi_enable(&mdev->napi[i]);
> + napi_schedule(&mdev->napi[i]);
> + }
> + napi_enable(&mdev->tx_napi);
> + napi_schedule(&mdev->tx_napi);
> +
> + return 0;
> +}
> +
> MODULE_DEVICE_TABLE(pci, mt76pci_device_table);
> MODULE_FIRMWARE(MT7662_FIRMWARE);
> MODULE_FIRMWARE(MT7662_ROM_PATCH);
> @@ -113,6 +167,10 @@ static struct pci_driver mt76pci_driver = {
> .id_table = mt76pci_device_table,
> .probe = mt76pci_probe,
> .remove = mt76pci_remove,
> +#ifdef CONFIG_PM
> + .suspend = mt76x2e_suspend,
> + .resume = mt76x2e_resume,
> +#endif /* CONFIG_PM */
> };
>
> module_pci_driver(mt76pci_driver);
> --
> 2.26.2

Unfortunately, it seems it did little change to my setup. The resume
time shrunk it seems (but is still noticeable), and the system survived
2 suspend/resume cycles, but after the third resume the following
happened:

===
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: MCU message 2 (seq 11) timed out
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: MCU message 30 (seq 12) timed out
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: MCU message 30 (seq 13) timed out
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: Firmware Version: 0.0.00
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: Build: 1
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: Build Time: 201507311614____
Äen 18 23:11:58 spock kernel: mt76x2e 0000:01:00.0: Firmware running!
Äen 18 23:11:58 spock kernel: ieee80211 phy0: Hardware restart was requested
Äen 18 23:11:59 spock kernel: mt76x2e 0000:01:00.0: MCU message 2 (seq 1) timed out
Äen 18 23:11:59 spock kernel: mt76x2e 0000:01:00.0: Firmware Version: 0.0.00
Äen 18 23:11:59 spock kernel: mt76x2e 0000:01:00.0: Build: 1
Äen 18 23:11:59 spock kernel: mt76x2e 0000:01:00.0: Build Time: 201507311614____
Äen 18 23:11:59 spock kernel: mt76x2e 0000:01:00.0: Firmware running!
Äen 18 23:11:59 spock kernel: ieee80211 phy0: Hardware restart was requested
Äen 18 23:12:00 spock kernel: mt76x2e 0000:01:00.0: MCU message 30 (seq 3) timed out
Äen 18 23:12:01 spock kernel: mt76x2e 0000:01:00.0: MCU message 30 (seq 4) timed out
Äen 18 23:12:01 spock kernel: mt76x2e 0000:01:00.0: Firmware Version: 0.0.00
Äen 18 23:12:01 spock kernel: mt76x2e 0000:01:00.0: Build: 1
Äen 18 23:12:01 spock kernel: mt76x2e 0000:01:00.0: Build Time: 201507311614____
Äen 18 23:12:01 spock kernel: mt76x2e 0000:01:00.0: Firmware running!
Äen 18 23:12:01 spock kernel: ieee80211 phy0: Hardware restart was requested
Äen 18 23:12:02 spock kernel: ------------[ cut here ]------------
Äen 18 23:12:02 spock kernel: WARNING: CPU: 3 PID: 171 at net/mac80211/util.c:2270 ieee80211_reconfig+0x234/0x1700 [mac80211]
Äen 18 23:12:02 spock kernel: Modules linked in: cmac ccm bridge stp llc nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables msr tun nfnetlink nls_iso8859_1 nls_cp437 vfat fat mt76x2e mt76x2_common mt76x02_lib mt76 mac80211 intel_rapl_msr snd_hda_codec_hdmi snd_hda_codec_cirrus mei_hdcp snd_hda_codec_generic cfg80211 intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp dell_laptop iTCO_wdt snd_hda_intel kvm_intel iTCO_vendor_support dell_wmi snd_intel_dspcfg sparse_keymap snd_hda_codec ledtrig_audio wmi_bmof dell_smbios snd_hda_core kvm rtsx_usb_ms dell_wmi_descriptor memstick dcdbas snd_hwdep dell_smm_hwmon irqbypass psmouse intel_cstate snd_pcm intel_uncore joydev intel_rapl_perf mousedev mei_me alx rfkill input_leds snd_timer i2c_i801 snd mei lpc_ich libarc4 mdio soundcore battery wmi evdev dell_smo8800 mac_hid ac tcp_bbr crypto_user ip_tables x_tables xfs dm_thin_pool dm_persistent_data dm_bio_prison dm_bufio libcrc32c crc32c_generic dm_crypt hid_logitech_hidpp hid_logitech_dj
Äen 18 23:12:02 spock kernel: hid_generic usbhid hid rtsx_usb_sdmmc mmc_core rtsx_usb dm_mod raid10 serio_raw atkbd libps2 md_mod crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel crypto_simd cryptd glue_helper xhci_pci xhci_hcd ehci_pci ehci_hcd i8042 serio i915 intel_gtt i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core drm agpgart
Äen 18 23:12:02 spock kernel: CPU: 3 PID: 171 Comm: kworker/3:3 Not tainted 5.7.0-pf3 #1
Äen 18 23:12:02 spock kernel: Hardware name: Dell Inc. Vostro 3360/0F5DWF, BIOS A18 09/25/2013
Äen 18 23:12:02 spock kernel: Workqueue: events_freezable ieee80211_restart_work [mac80211]
Äen 18 23:12:02 spock kernel: RIP: 0010:ieee80211_reconfig+0x234/0x1700 [mac80211]
Äen 18 23:12:02 spock kernel: Code: 83 b8 0b 00 00 83 e0 fd 83 f8 04 74 e6 48 8b 83 90 04 00 00 a8 01 74 db 48 89 de 48 89 ef e8 03 dc fb ff 41 89 c7 85 c0 74 c9 <0f> 0b 48 8b 5b 08 4c 8b 24 24 48 3b 1c 24 75 12 e9 51 fe ff ff 48
Äen 18 23:12:02 spock kernel: RSP: 0018:ffffa87c40403df0 EFLAGS: 00010286
Äen 18 23:12:02 spock kernel: RAX: 00000000fffffff0 RBX: ffff9fe028f6e900 RCX: 0000000000000008
Äen 18 23:12:02 spock kernel: RDX: 0000000000000000 RSI: 0000000000000100 RDI: 0000000000000100
Äen 18 23:12:02 spock kernel: RBP: ffff9fe0283787e0 R08: 0000000000000000 R09: 0000000000000001
Äen 18 23:12:02 spock kernel: R10: 0000000000000001 R11: 0000000000000000 R12: ffff9fe0283798d0
Äen 18 23:12:02 spock kernel: R13: 00000000ffffffff R14: 0000000000000000 R15: 00000000fffffff0
Äen 18 23:12:02 spock kernel: FS: 0000000000000000(0000) GS:ffff9fe02f2c0000(0000) knlGS:0000000000000000
Äen 18 23:12:02 spock kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Äen 18 23:12:02 spock kernel: CR2: 00007f313b33a940 CR3: 000000012ea0a002 CR4: 00000000001706e0
Äen 18 23:12:02 spock kernel: Call Trace:
Äen 18 23:12:02 spock kernel: ieee80211_restart_work+0xb7/0xe0 [mac80211]
Äen 18 23:12:02 spock kernel: process_one_work+0x1d4/0x3c0
Äen 18 23:12:02 spock kernel: worker_thread+0x228/0x470
Äen 18 23:12:02 spock kernel: ? process_one_work+0x3c0/0x3c0
Äen 18 23:12:02 spock kernel: kthread+0x19c/0x1c0
Äen 18 23:12:02 spock kernel: ? __kthread_init_worker+0x30/0x30
Äen 18 23:12:02 spock kernel: ret_from_fork+0x35/0x40
Äen 18 23:12:02 spock kernel: ---[ end trace e017bc3573bd9bf2 ]---
Äen 18 23:12:02 spock kernel: ------------[ cut here ]------------
Äen 18 23:12:02 spock kernel: wlp1s0: Failed check-sdata-in-driver check, flags: 0x0
Äen 18 23:12:02 spock kernel: WARNING: CPU: 3 PID: 171 at net/mac80211/driver-ops.h:17 drv_remove_interface+0x11f/0x130 [mac80211]
Äen 18 23:12:02 spock kernel: Modules linked in: cmac ccm bridge stp llc nft_ct nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables msr tun nfnetlink nls_iso8859_1 nls_cp437 vfat fat mt76x2e mt76x2_common mt76x02_lib mt76 mac80211 intel_rapl_msr snd_hda_codec_hdmi snd_hda_codec_cirrus mei_hdcp snd_hda_codec_generic cfg80211 intel_rapl_common x86_pkg_temp_thermal intel_powerclamp coretemp dell_laptop iTCO_wdt snd_hda_intel kvm_intel iTCO_vendor_support dell_wmi snd_intel_dspcfg sparse_keymap snd_hda_codec ledtrig_audio wmi_bmof dell_smbios snd_hda_core kvm rtsx_usb_ms dell_wmi_descriptor memstick dcdbas snd_hwdep dell_smm_hwmon irqbypass psmouse intel_cstate snd_pcm intel_uncore joydev intel_rapl_perf mousedev mei_me alx rfkill input_leds snd_timer i2c_i801 snd mei lpc_ich libarc4 mdio soundcore battery wmi evdev dell_smo8800 mac_hid ac tcp_bbr crypto_user ip_tables x_tables xfs dm_thin_pool dm_persistent_data dm_bio_prison dm_bufio libcrc32c crc32c_generic dm_crypt hid_logitech_hidpp hid_logitech_dj
Äen 18 23:12:02 spock kernel: hid_generic usbhid hid rtsx_usb_sdmmc mmc_core rtsx_usb dm_mod raid10 serio_raw atkbd libps2 md_mod crct10dif_pclmul crc32_pclmul crc32c_intel ghash_clmulni_intel aesni_intel crypto_simd cryptd glue_helper xhci_pci xhci_hcd ehci_pci ehci_hcd i8042 serio i915 intel_gtt i2c_algo_bit drm_kms_helper syscopyarea sysfillrect sysimgblt fb_sys_fops cec rc_core drm agpgart
Äen 18 23:12:02 spock kernel: CPU: 3 PID: 171 Comm: kworker/3:3 Tainted: G W 5.7.0-pf3 #1
Äen 18 23:12:02 spock kernel: Hardware name: Dell Inc. Vostro 3360/0F5DWF, BIOS A18 09/25/2013
Äen 18 23:12:02 spock kernel: Workqueue: events_freezable ieee80211_restart_work [mac80211]
Äen 18 23:12:02 spock kernel: RIP: 0010:drv_remove_interface+0x11f/0x130 [mac80211]
Äen 18 23:12:02 spock kernel: Code: a0 57 f0 c2 e9 4b ff ff ff 48 8b 86 78 04 00 00 48 8d b6 98 04 00 00 48 c7 c7 e8 ef f8 c0 48 85 c0 48 0f 45 f0 e8 99 2e fa c2 <0f> 0b 5b 5d 41 5c c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00
Äen 18 23:12:02 spock kernel: RSP: 0018:ffffa87c40403c80 EFLAGS: 00010282
Äen 18 23:12:02 spock kernel: RAX: 0000000000000000 RBX: ffff9fe028f6e900 RCX: 0000000000000000
Äen 18 23:12:02 spock kernel: RDX: 0000000000000001 RSI: 0000000000000082 RDI: 00000000ffffffff
Äen 18 23:12:02 spock kernel: RBP: ffff9fe028379930 R08: 00000000000004c9 R09: 0000000000000001
Äen 18 23:12:02 spock kernel: R10: 0000000000000001 R11: 0000000000006fc0 R12: ffff9fe028379000
Äen 18 23:12:02 spock kernel: R13: ffff9fe028f6f4b8 R14: ffff9fe028378ca0 R15: ffff9fe0283787e0
Äen 18 23:12:02 spock kernel: FS: 0000000000000000(0000) GS:ffff9fe02f2c0000(0000) knlGS:0000000000000000
Äen 18 23:12:02 spock kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
Äen 18 23:12:02 spock kernel: CR2: 00007f313b33a940 CR3: 000000012ea0a002 CR4: 00000000001706e0
Äen 18 23:12:02 spock kernel: Call Trace:
Äen 18 23:12:02 spock kernel: ieee80211_do_stop+0x5af/0x8c0 [mac80211]
Äen 18 23:12:02 spock kernel: ieee80211_stop+0x16/0x20 [mac80211]
Äen 18 23:12:02 spock kernel: __dev_close_many+0xaa/0x120
Äen 18 23:12:02 spock kernel: dev_close_many+0xa1/0x2b0
Äen 18 23:12:02 spock kernel: dev_close+0x6d/0x90
Äen 18 23:12:02 spock kernel: cfg80211_shutdown_all_interfaces+0x71/0xd0 [cfg80211]
Äen 18 23:12:02 spock kernel: ieee80211_reconfig+0xa2/0x1700 [mac80211]
Äen 18 23:12:02 spock kernel: ieee80211_restart_work+0xb7/0xe0 [mac80211]
Äen 18 23:12:02 spock kernel: process_one_work+0x1d4/0x3c0
Äen 18 23:12:02 spock kernel: worker_thread+0x228/0x470
Äen 18 23:12:02 spock kernel: ? process_one_work+0x3c0/0x3c0
Äen 18 23:12:02 spock kernel: kthread+0x19c/0x1c0
Äen 18 23:12:02 spock kernel: ? __kthread_init_worker+0x30/0x30
Äen 18 23:12:02 spock kernel: ret_from_fork+0x35/0x40
Äen 18 23:12:02 spock kernel: ---[ end trace e017bc3573bd9bf3 ]---
===

Do you still want me to try Felix's tree, or there's something else I
can try?

Thank you.

--
Best regards,
Oleksandr Natalenko (post-factum)
Principal Software Maintenance Engineer

Next message: Greg Kroah-Hartman: "[PATCH 4.19 201/267] PCI: Avoid FLR for AMD Starship USB 3.0"
Previous message: Greg Kroah-Hartman: "[PATCH 4.19 185/267] platform/x86: intel-hid: Add a quirk to support HP Spectre X2 (2015)"
In reply to: Lorenzo Bianconi: "Re: mt7612 suspend/resume issue"
Next in thread: Lorenzo Bianconi: "Re: mt7612 suspend/resume issue"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]