Re: [PATCH 1/2] net: qrtr: Migrate nameservice to kernel from userspace

[Manivannan Sadhasivam]

Hi, 

On 17 June 2020 12:18:06 AM IST, Qais Yousef <qais.yousef@xxxxxxx> wrote:
>Hi Manivannan, David
>
>On 02/13/20 14:44, Manivannan Sadhasivam wrote:
>
>[...]
>
>> +	trace_printk("advertising new server [%d:%x]@[%d:%d]\n",
>> +		     srv->service, srv->instance, srv->node, srv->port);
>
>I can't tell exactly from the discussion whether this is the version
>that got
>merged into 5.7 or not, but it does match the commit message.
>

This got merged and there was a follow up patch to replace trace_printk() with tracepoints got merged as well. 

Thanks, 
Mani

>This patch introduces several trace_printk() which AFAIK is intended
>for
>debugging only and shouldn't make it into mainline kernels.
>
>It causes this big message to be printed to the log too
>
>[    0.000000]
>**********************************************************
>[    0.000000] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE  
>**
>[    0.000000] **                                                     
>**
>[    0.000000] ** trace_printk() being used. Allocating extra memory. 
>**
>[    0.000000] **                                                     
>**
>[    0.000000] ** This means that this is a DEBUG kernel and it is    
>**
>[    0.000000] ** unsafe for production use.                          
>**
>[    0.000000] **                                                     
>**
>[    0.000000] ** If you see this message and you are not debugging   
>**
>[    0.000000] ** the kernel, report this immediately to your vendor! 
>**
>[    0.000000] **                                                     
>**
>[    0.000000] **   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE  
>**
>[    0.000000]
>**********************************************************
>
>Shouldn't this be replaced with one of pr_*() variants instead?
>
>Thanks
>
>--
>Qais Yousef

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.