Re: [PATCH 11/21] perf/x86/intel/lbr: Support LBR_CTL

[Peter Zijlstra]

On Fri, Jun 19, 2020 at 07:03:59AM -0700, kan.liang@xxxxxxxxxxxxxxx wrote:
> -	if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map) {
> +	if (x86_pmu.extra_regs || x86_pmu.lbr_sel_map || x86_pmu.lbr_ctl_map) {

> +	union {
> +		u64		lbr_sel_mask;		   /* LBR_SELECT valid bits */
> +		u64		lbr_ctl_mask;		   /* LBR_CTL valid bits */
> +	};

This makes absolutely no sense. There is hoping the compiler realizes
how stupid that is and fixes it for you, but shees.

Please, just keep the old name.