Re: Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

[Simao Gomes Viana]

On Fri, Jun 19, 2020 at 11:29:59AM -0700, Joe Perches wrote:
> On Fri, 2020-06-19 at 20:08 +0200, Simao Gomes Viana wrote:
> > This fixes all errors that scripts/checkpatch.pl
> > reports about drivers/cdrom/*.c and a lot of warnings
> > as well. I skipped warnings that I don't know whether
> > fixing them will break anything.
> 
> This is too many changes in a single patch to verify
> them easily.
> 
> If you really want to change this file, and it's likely
> not particularly necessary, I suggest that you send a
> patch series that where each patch individually does:
> 
> 1: Horizontal whitespace only changes
>    o Trim trailing whitespace
>    o Add alignment whitespace
>    o Add operator spacing whitespace
> 2: Vertical whitespace changes if any
> 3: Convert embedded assignments to multiple lines
> 4: Comment style updates
> 
> And whatever other specific style changes necessary
> to properly and easily identify them as correct.
> 
>

Thank you for your feedback.
I will follow up with a proper set of patches as you 
described in your response.

I'm fairly new to submitting patches. Although I have read
through some of the guidelines there is always room for
improvement so it's great to get feedback like that.