Re: [PATCH 1/1] pci: controller: cadence: fix wrong path in comment

From: Bjorn Helgaas
Date: Fri Jun 19 2020 - 15:31:20 EST


On Fri, Jun 19, 2020 at 05:11:34PM +0200, Flavio Suligoi wrote:
> All native pci drivers are in drivers/pci/controller,
> but this comment still refers to the old pathname,
> when all pci drivers were located directly under the
> drivers/pci directory.
>
> Signed-off-by: Flavio Suligoi <f.suligoi@xxxxxxx>
> ---
> drivers/pci/controller/cadence/pcie-cadence-ep.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/cadence/pcie-cadence-ep.c b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> index 1c15c8352125..2a48b34ff249 100644
> --- a/drivers/pci/controller/cadence/pcie-cadence-ep.c
> +++ b/drivers/pci/controller/cadence/pcie-cadence-ep.c
> @@ -276,7 +276,7 @@ static int cdns_pcie_ep_send_legacy_irq(struct cdns_pcie_ep *ep, u8 fn, u8 intx)
> cdns_pcie_ep_assert_intx(ep, fn, intx, true);
> /*
> * The mdelay() value was taken from dra7xx_pcie_raise_legacy_irq()
> - * from drivers/pci/dwc/pci-dra7xx.c
> + * from drivers/pci/controller/dwc/pci-dra7xx.c

I think the function name by itself would be enough, so maybe we
should remove the filename completely.

> */
> mdelay(1);
> cdns_pcie_ep_assert_intx(ep, fn, intx, false);
> --
> 2.17.1
>