Re: [PATCH 1/2] drivers: cdrom: fix all errors reported by checkpatch

[Jens Axboe]

On 6/19/20 12:08 PM, Simao Gomes Viana wrote:
> This fixes all errors that scripts/checkpatch.pl
> reports about drivers/cdrom/*.c and a lot of warnings
> as well. I skipped warnings that I don't know whether
> fixing them will break anything.
> 
> Before:
> drivers/cdrom/cdrom.c:
>     total: 118 errors, 126 warnings, 3794 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 16 warnings, 873 lines checked
> 
> After:
> drivers/cdrom/cdrom.c:
>     total: 0 errors, 38 warnings, 3866 lines checked
> drivers/cdrom/gdrom.c:
>     total: 0 errors, 3 warnings, 882 lines checked
> 
> Test: scripts/checkpatch.pl --file drivers/cdrom/*.c
> Test: make drivers/cdrom/cdrom.o
> Test: make CONFIG_GDROM=y drivers/cdrom/gdrom.o # partial
> Test: compiles, boots on 5.7.4
> Test: CD ROM works (tested with Audio CD)

Let's please not do this, it's a lot of churn for zero gain.

-- 
Jens Axboe