Re: Commit 25f12ae45fc1 ("maccess: rename probe_kernel_address to get_kernel_nofault") causing several OOPSes

[Kenneth R. Crudup]

> > Thing is, there's other examples of the previous version in the kernel tree- any
> > chance there's a usage conflict (Thunderbolt has a ROM in it, maybe something in
> > "probe_roms.c"? (Just guessing, no idea):

On Fri, 19 Jun 2020, Christoph Hellwig wrote:

> Maybe.  But nothing looks strange there.  Just to re-reconfirm, you had to
> revert "maccess: rename probe_kernel_address to get_kernel_nofault",
> "maccess: make get_kernel_nofault() check for minimal type compatibility"
> wasn't enough?

Yeah, the only commit I had to revert was this one. BUT:

> Below is a patch to do a "partial revert" for probe_roms.c.  I'd be
> totally surprised if it changes anything from staring at it for while,
> but anyway..

So, be totally surprised :) I've just booted with "maccess: rename
probe_kernel_address to get_kernel_nofault" intact and your probe_roms.c
patch with no issues.

(Perhaps there's some sort of compiler optimization going on?)

	-Kenny

-- 
Kenneth R. Crudup  Sr. SW Engineer, Scott County Consulting, Orange County CA