Re: [PATCH v2] video: fbdev: uvesafb: fix "noblank" option handling

From: Sam Ravnborg
Date: Sun Jun 21 2020 - 04:13:59 EST


On Tue, Jun 09, 2020 at 11:29:43AM +0200, Bartlomiej Zolnierkiewicz wrote:
> Fix the recent regression.
>
> Fixes: dbc7ece12a38 ("video: uvesafb: use true,false for bool variables")
> Cc: Jason Yan <yanaijie@xxxxxxxxxx>
> Reviewed-by: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>

Hi Bartlomiej

I was processing drm-misc-fixes patches so I went ahead and applied
this.
Thanks for fixing this up.

Sam

> ---
> v2:
> - added Reviewed-by tag from Sam
> - removed no longer working Michal's email address from Cc:
>
> drivers/video/fbdev/uvesafb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: b/drivers/video/fbdev/uvesafb.c
> ===================================================================
> --- a/drivers/video/fbdev/uvesafb.c
> +++ b/drivers/video/fbdev/uvesafb.c
> @@ -1836,7 +1836,7 @@ static int uvesafb_setup(char *options)
> else if (!strcmp(this_opt, "noedid"))
> noedid = true;
> else if (!strcmp(this_opt, "noblank"))
> - blank = true;
> + blank = false;
> else if (!strncmp(this_opt, "vtotal:", 7))
> vram_total = simple_strtoul(this_opt + 7, NULL, 0);
> else if (!strncmp(this_opt, "vremap:", 7))
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel