Re: [PATCH 1/3] crypto: ccree: fix resource leak on error path

From: Markus Elfring
Date: Sun Jun 21 2020 - 05:28:27 EST


> Fix a small resource leak on the error path of cipher processing.

Would you like to add the tag âFixesâ to the commit message?


â
> +++ b/drivers/crypto/ccree/cc_cipher.c
â
> @@ -190,21 +198,19 @@ static int cc_cipher_init(struct crypto_tfm *tfm)
â
> - return rc;
> +out_key:
> + kfree(ctx_p->user.key);
> +out_shash:
> + crypto_free_shash(ctx_p->shash_tfm);
â

How do you think about to replace the prefix âoutâ by âfreeâ in these labels?

Regards,
Markus