Re: [PATCH 3/8] soc: qcom: socinfo: Add socinfo entry for SDM630

[Alexey Minnekhanov]

Hi,
I also wanted to send this, but in this form:

[PATCH] soc: qcom: socinfo: Add soc information for SDM630/636/660

Add socinfo support for SDM630/636/660.

---
 drivers/soc/qcom/socinfo.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index 5983c6ffb078..398a3c77954e 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -202,8 +202,14 @@ static const struct soc_id soc_id[] = {
  { 310, "MSM8996AU" },
  { 311, "APQ8096AU" },
  { 312, "APQ8096SG" },
+ { 317, "SDM660" },
+ { 318, "SDM630" },
  { 321, "SDM845" },
+ { 324, "SDA660" },
+ { 327, "SDA630" },
  { 341, "SDA845" },
+ { 345, "SDM636" },
+ { 346, "SDA636" },
 };

I think it would be great to have all IDs of compatible SoCs at once.

I've tested it on my sdm660 by adding some printks in probe:
[ 1.609040] socinfo: family = Snapdragon
[ 1.609043] socinfo: machine = SDM660
[ 1.619712] socinfo: soc_id = 317
[ 1.630347] socinfo: revision = 1.0

ÐÐ, 22 ÐÑÐ. 2020 Ð. Ð 00:40, Konrad Dybcio <konradybcio@xxxxxxxxx>:
>
> This patch adds missing soc ID for SDM630.
>
> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxx>
> ---
>  drivers/soc/qcom/socinfo.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
> index 5983c6ffb078..705f142ee588 100644
> --- a/drivers/soc/qcom/socinfo.c
> +++ b/drivers/soc/qcom/socinfo.c
> @@ -202,6 +202,7 @@ static const struct soc_id soc_id[] = {
>         { 310, "MSM8996AU" },
>         { 311, "APQ8096AU" },
>         { 312, "APQ8096SG" },
> +       { 318, "SDM630" },
>         { 321, "SDM845" },
>         { 341, "SDA845" },
>  };
> --
> 2.27.0
>