Re: [PATCH] remoteproc: qcom: q6v5-mss: Fix kfree build error

[Naresh Kamboju]

On Sun, 21 Jun 2020 at 13:12, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
>
> On Tue 16 Jun 23:56 PDT 2020, Naresh Kamboju wrote:
>
> > This patch adds linux/slab.h to fix build error in qcom_q6v5_mss.c
> >
> > Build error:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:
> >   In function âq6v5_mpss_init_imageâ:
> >  ../drivers/remoteproc/qcom_q6v5_mss.c:772:3:
> >   error: implicit declaration of function âkfreeâ;
> >   did you mean âvfreeâ? [-Werror=implicit-function-declaration]
> >    772 |   kfree(metadata);
> >        |   ^~~~~
> >        |   vfree
> >
> > Signed-off-by: Naresh Kamboju <naresh.kamboju@xxxxxxxxxx>
>
> Thanks for the patch Naresh, it looks correct but I've not seen this
> build error myself. Could you please let me know what you built to get
> this and if you have any suggestion on what caused it? (So we can add a
> Fixes: tag etc)

Thanks for the review.
This was an arm64 modules build failure on linux -next 20200616 tag.
This fix has already been taken care of by
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> and got merged.
Fixes: f0187db056dc ("iov_iter: Move unnecessary inclusion of...")

ref:
https://lore.kernel.org/lkml/20200616010502.GA28834@xxxxxxxxxxxxxxxxxxx/

- Naresh