Re: [PATCH v5 1/2] dt-bindings: mfd: Add ENE KB3930 Embedded Controller binding

[Lubomir Rintel]

On Mon, Jun 22, 2020 at 07:53:50AM +0100, Lee Jones wrote:
> On Wed, 17 Jun 2020, Lubomir Rintel wrote:
> 
> > Add binding document for the ENE KB3930 Embedded Controller.
> > 
> > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx>
> > Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> > 
> > ---
> > Changes since v4:
> > - Collected Rob's Reviewed-by
> > 
> > Changes since v1:
> > - Addressed binding validation failure
> > 
> >  .../devicetree/bindings/mfd/ene-kb3930.yaml   | 55 +++++++++++++++++++
> >  1 file changed, 55 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
> > new file mode 100644
> > index 0000000000000..005f5cb59ab12
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/ene-kb3930.yaml
> > @@ -0,0 +1,55 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/ene-kb3930.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ENE KB3930 Embedded Controller bindings
> 
> Please expand ENE.

I don't think it's an acronym; seems like the company is just called
"ENE".
> 
> > +description: |
> > +  This binding describes the ENE KB3930 Embedded Controller attached to a
> > +  I2C bus.
> 
> Nit: "an I2C bus"
> 
> > +maintainers:
> > +  - Lubomir Rintel <lkundrak@xxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +        - dell,wyse-ariel-ec  # Dell Wyse Ariel board (3020)
> > +      - const: ene,kb3930
> > +  reg:
> > +    maxItems: 1
> > +
> > +  off-gpios:
> > +    description: GPIO used with the shutdown protocol on Ariel
> > +    maxItems: 2
> > +
> > +  system-power-controller: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +
> > +    i2c {
> > +      #address-cells = <1>;
> > +      #size-cells = <0>;
> > +
> > +      embedded-controller@58 {
> > +        compatible = "dell,wyse-ariel-ec", "ene,kb3930";
> > +        reg = <0x58>;
> > +        system-power-controller;
> > +
> > +        off-gpios = <&gpio 126 GPIO_ACTIVE_HIGH>,
> > +                    <&gpio 127 GPIO_ACTIVE_HIGH>;
> > +      };
> > +    };
> > +
> > +...
> 
> -- 
> Lee Jones [æçæ]
> Senior Technical Lead - Developer Services
> Linaro.org â Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog