Re: [PATCH v3] venus: fix multiple encoder crash

From: Doug Anderson
Date: Mon Jun 22 2020 - 16:28:40 EST


Hi,

On Mon, Jun 22, 2020 at 5:16 AM Stanimir Varbanov
<stanimir.varbanov@xxxxxxxxxx> wrote:
>
> From: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx>
>
> Currently we are considering the instances which are available
> in core->inst list for load calculation in min_loaded_core()
> function, but this is incorrect because by the time we call
> decide_core() for second instance, the third instance not
> filled yet codec_freq_data pointer.
>
> Solve this by considering the instances whose session has started.
>
> Cc: stable@xxxxxxxxxxxxxxx # v5.7+
> Fixes: 4ebf969375bc ("media: venus: introduce core selection")
> Signed-off-by: Mansur Alisha Shaik <mansur@xxxxxxxxxxxxxx>
> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@xxxxxxxxxx>
> ---
>
> v3: Cc stable and add Fixes tag.
>
> drivers/media/platform/qcom/venus/pm_helpers.c | 4 ++++
> 1 file changed, 4 insertions(+)

The code is the same, so carrying over my tested tag [1]:

Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

[1] https://lore.kernel.org/r/CAD=FV=Vt8je1AtT8id-rPC3JToF_7uGKpC-uDuSpzCkwi3e4Sw@xxxxxxxxxxxxxx/