Re: [PATCH net-next v3 4/7] net: phy: add backplane kr driver support

[Jakub Kicinski]

On Mon, 22 Jun 2020 16:35:21 +0300 Florinel Iordache wrote:
> Add support for backplane kr generic driver including link training
> (ieee802.3ap/ba) and fixed equalization algorithm
> 
> Signed-off-by: Florinel Iordache <florinel.iordache@xxxxxxx>

drivers/net/phy/backplane/backplane.c:60:11: warning: symbol 'backplane_common_features_array' was not declared. Should it be static?
drivers/net/phy/backplane/backplane.c:66:11: warning: symbol 'backplane_protocol_features_array' was not declared. Should it be static?
drivers/net/phy/backplane/backplane.c:1204:40: warning: incorrect type in assignment (different address spaces)
drivers/net/phy/backplane/backplane.c:1204:40:    expected void *[assigned] reg_base
drivers/net/phy/backplane/backplane.c:1204:40:    got void [noderef] <asn:2> *reg_base
drivers/net/phy/backplane/backplane.c: In function ÃâËbp_kr_state_machineÃââ:
drivers/net/phy/backplane/backplane.c:590:27: warning: variable ÃâËbpdevÃââ set but not used [-Wunused-but-set-variable]
  590 |  struct backplane_device *bpdev;
      |                           ^~~~~
drivers/net/phy/backplane/link_training.c: In function ÃâËlt_train_remote_txÃââ:
drivers/net/phy/backplane/link_training.c:557:6: warning: variable ÃâËlp_resp_timeÃââ set but not used [-Wunused-but-set-variable]
  557 |  u64 lp_resp_time;
      |      ^~~~~~~~~~~~
drivers/net/phy/backplane/link_training.c: In function ÃâËlt_train_local_txÃââ:
drivers/net/phy/backplane/link_training.c:1143:15: warning: variable ÃâËold_ld_statusÃââ set but not used [-Wunused-but-set-variable]
 1143 |  int request, old_ld_status;
      |               ^~~~~~~~~~~~~