Re: [PATCH v2 3/3] x86/boot: Warn on orphan section placement

[Fangrui Song]

On 2020-06-22, Kees Cook wrote:
> On Mon, Jun 22, 2020 at 03:06:28PM -0700, Fangrui Song wrote:
> > LLD may report warnings for 3 synthetic sections if they are orphans:
> >
> > ld.lld: warning: <internal>:(.symtab) is being placed in '.symtab'
> > ld.lld: warning: <internal>:(.shstrtab) is being placed in '.shstrtab'
> > ld.lld: warning: <internal>:(.strtab) is being placed in '.strtab'
> >
> > Are they described?
>
> Perhaps:
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index db600ef218d7..57e9c142e401 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -792,6 +792,9 @@
> 		.stab.exclstr 0 : { *(.stab.exclstr) }			\
> 		.stab.index 0 : { *(.stab.index) }			\
> 		.stab.indexstr 0 : { *(.stab.indexstr) }		\
> +		.symtab 0 : { *(.symtab) }				\
> +		.strtab 0 : { *(.strtab) }				\
> +		.shstrtab 0 : { *(.shstrtab) }				\
> 		.comment 0 : { *(.comment) }
>
> #ifdef CONFIG_GENERIC_BUG

This LGTM. Nit: .comment before .symtab is a more common order.

Reviewed-by: Fangrui Song <maskray@xxxxxxxxxx>