Re: [PATCH 13/16] mm: support THP migration to device private memory
From: John Hubbard
Date: Mon Jun 22 2020 - 19:02:08 EST
On 2020-06-22 15:33, Yang Shi wrote:
On Mon, Jun 22, 2020 at 3:30 PM Yang Shi <shy828301@xxxxxxxxx> wrote:
On Mon, Jun 22, 2020 at 2:53 PM Zi Yan <ziy@xxxxxxxxxx> wrote:
On 22 Jun 2020, at 17:31, Ralph Campbell wrote:
On 6/22/20 1:10 PM, Zi Yan wrote:
On 22 Jun 2020, at 15:36, Ralph Campbell wrote:
On 6/21/20 4:20 PM, Zi Yan wrote:
On 19 Jun 2020, at 17:56, Ralph Campbell wrote:
...
Ying(ccâd) developed the code to swapout and swapin THP in one piece: https://lore.kernel.org/linux-mm/20181207054122.27822-1-ying.huang@xxxxxxxxx/.
I am not sure whether the patchset makes into mainstream or not. It could be a good technical reference
for swapping in device private pages, although swapping in pages from disk and from device private
memory are two different scenarios.
Since the device private memory swapin impacts core mm performance, we might want to discuss your patches
with more people, like the ones from Yingâs patchset, in the next version.
I believe Ying will give you more insights about how THP swap works.
But, IMHO device memory migration (migrate to system memory) seems
like THP CoW more than swap.
A fine point: overall, the desired behavior is "migrate", not CoW.
That's important. Migrate means that you don't leave a page behind, even
a read-only one. And that's exactly how device private migration is
specified.
We should try to avoid any erosion of clarity here. Even if somehow
(really?) the underlying implementation calls this THP CoW, the actual
goal is to migrate pages over to the device (and back).
When migrating in:
Sorry for my fat finger, hit sent button inadvertently, let me finish here.
When migrating in:
- if THP is enabled: allocate THP, but need handle allocation
failure by falling back to base page
- if THP is disabled: fallback to base page
OK, but *all* page entries (base and huge/large pages) need to be cleared,
when migrating to device memory, unless I'm really confused here.
So: not CoW.
thanks,
--
John Hubbard
NVIDIA