Re: [PATCH v4] coccinelle: misc: add array_size_dup script to detect missed overflow checks

[Markus Elfring]

> Changes in v2:
â
> - assignment operator used

I prefer the distinction for the application of corresponding metavariables.


> Changes in v3:
â
>  - \(&E1\|&E2\) changed to &\(E1\|E2\)

Would it be more helpful to mention the movement of the ampersand
before SmPL disjunctions?


â
>+/// Three types of patterns for these functions:

Will another adjustment be needed according to your information âduplicates warning removedâ?


â
> +virtual context
> +virtual report
> +virtual org

Can the following SmPL code variant ever become more attractive?

+virtual context, report, org


â
> +expression subE1 <= as.E1;
> +expression subE2 <= as.E2;
> +expression as.E1, as.E2, E3;

How do you think about the following SmPL code variant?

+expression subE1 <= as.E1,
+           subE2 <= as.E2,
+           as.E1, as.E2, E3;


â
> +msg = "WARNING: array_size is used later (line %s) to compute the same size" % (p2[0].line)
> +coccilib.report.print_report(p1[0], msg)

Please omit the extra Python variable âmsgâ for the passing of such simple message objects.

What does hinder you to take the proposed script variants better into account?

Regards,
Markus