Re: [PATCH v3 1/7] pinctrl: qcom: spmi-gpio: Add pm660(l) compatibility

From: Bjorn Andersson
Date: Tue Jun 23 2020 - 03:29:11 EST


On Mon 22 Jun 12:25 PDT 2020, Konrad Dybcio wrote:

> Add support for pm660(l) SPMI GPIOs. The PMICs feature
> 13 and 12 GPIOs respectively, though with a lot of
> holes inbetween.
>
> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxx>

Didn't I ack this change in v2? If so please remember to add such tags
when you resubmit the change...

Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

Regards,
Bjorn

> ---
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index fe0be8a6ebb7..95ca66e24e7c 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -1118,6 +1118,10 @@ static const struct of_device_id pmic_gpio_of_match[] = {
> { .compatible = "qcom,pma8084-gpio", .data = (void *) 22 },
> /* pms405 has 12 GPIOs with holes on 1, 9, and 10 */
> { .compatible = "qcom,pms405-gpio", .data = (void *) 12 },
> + /* pm660 has 13 GPIOs with holes on 1, 5, 6, 7, 8 and 10 */
> + { .compatible = "qcom,pm660-gpio", .data = (void *) 13 },
> + /* pm660l has 12 GPIOs with holes on 1, 2, 10, 11 and 12 */
> + { .compatible = "qcom,pm660l-gpio", .data = (void *) 12 },
> /* pm8150 has 10 GPIOs with holes on 2, 5, 7 and 8 */
> { .compatible = "qcom,pm8150-gpio", .data = (void *) 10 },
> /* pm8150b has 12 GPIOs with holes on 3, r and 7 */
> --
> 2.27.0
>