Re: [PATCH v2 05/15] net: pylink.h: add kernel-doc descriptions for new fields at phylink_config

[Russell King - ARM Linux admin]

On Tue, Jun 23, 2020 at 09:09:01AM +0200, Mauro Carvalho Chehab wrote:
> Some fields were moved from struct phylink into phylink_config.
> Update the kernel-doc markups for the config struct accordingly
> 
> Fixes: 5c05c1dbb177 ("net: phylink, dsa: eliminate phylink_fixed_state_cb()")
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>

Reviewed-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx>

Thanks.

> ---
>  include/linux/phylink.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/phylink.h b/include/linux/phylink.h
> index cc5b452a184e..02ff1419d4be 100644
> --- a/include/linux/phylink.h
> +++ b/include/linux/phylink.h
> @@ -62,6 +62,10 @@ enum phylink_op_type {
>   * @dev: a pointer to a struct device associated with the MAC
>   * @type: operation type of PHYLINK instance
>   * @pcs_poll: MAC PCS cannot provide link change interrupt
> + * @poll_fixed_state: if true, starts link_poll,
> + *		      if MAC link is at %MLO_AN_FIXED mode.
> + * @get_fixed_state: callback to execute to determine the fixed link state,
> + *		     if MAC link is at %MLO_AN_FIXED mode.
>   */
>  struct phylink_config {
>  	struct device *dev;
> -- 
> 2.26.2
> 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!