Re: [1/7] irqchip: Fix potential resource leaks

[Tiezhu Yang]

On 06/24/2020 05:23 PM, Markus Elfring wrote:
> > > [PATCH v3 10/14 RESEND] irqchip/nvic: Fix potential resource leaks
> > > https://lore.kernel.org/linux-mips/1592984711-3130-11-git-send-email-yangtiezhu@xxxxxxxxxxx/
> > > https://lore.kernel.org/patchwork/patch/1263191/
> > >
> > >
> > > Can it matter to omit the word âpotentialâ from change descriptions
> > > after you detected that specific function calls were missing
> > > in if branches?
> > Oh, I find this issue through code review, I have no test environment
> > to trigger the error path, but I think it is better to release the resource
> > in the error path, so I use "potential" description.
> Did you determine that special function calls were generally missing
> in error cases?

Yes, I read many files in drivers/irqchip,
the resource is released in the error path.

> Were any known software analysis tools involved for the detection of
> questionable source code places?

kmemleak can detect memory leak,
but I do not know how to detect other kind of leaks.
I think consciously release resource in the error path can avoid leaks.

> Regards,
> Markus