Re: [PATCH 15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle

[Nicolas Saenz Julienne]

On Wed, 2020-06-24 at 17:11 +0300, Dan Carpenter wrote:
> On Tue, Jun 23, 2020 at 06:42:01PM +0200, Nicolas Saenz Julienne wrote:
> > @@ -437,12 +432,10 @@ static void service_free(struct shim_service *service)
> >  
> >  int32_t vchi_service_open(struct vchiq_instance *instance,
> >  	struct service_creation *setup,
> > -	struct vchi_service_handle **handle)
> > +	struct vchi_service **service)
> >  {
> > -	struct shim_service *service = service_alloc(instance, setup);
> > -
> > -	*handle = (struct vchi_service_handle *)service;
> >  
> > +	*service = service_alloc(instance, setup);
> >  	if (service) {
> 
> This should be checking "*service".
> 

Of course, thanks!

Reards,
Nicolas

Attachment: signature.asc
Description: This is a digitally signed message part