drivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c:368:15: sparse: sparse: incorrect type in assignment (different address spaces)

From: kernel test robot
Date: Wed Jun 24 2020 - 16:34:51 EST

tree: .config.gz< Description: application/gzip Sami Tolvanen: "[PATCH 07/22] kbuild: lto: merge module sections" Marcelo Ricardo Leitner: "[PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket" date ] [ thread ] [ subject ] [ author ] cm/linux/kernel/git/torvalds/linux.git">https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
use identifiers to define address spaces
.config)

-D__CHECK_ENDIAN__'

sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] vld_tid @@ got restricted __be32 [usertype] @@
expected unsigned int [usertype] vld_tid
got restricted __be32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] pgsz_tag_clr @@ got restricted __be32 [usertype] @@
expected unsigned int [usertype] pgsz_tag_clr
got restricted __be32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] max_offset @@ got restricted __be32 [usertype] @@
expected unsigned int [usertype] max_offset
got restricted __be32 [usertype]
sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned int [usertype] page_offset @@ got restricted __be32 [usertype] @@
expected unsigned int [usertype] page_offset
got restricted __be32 [usertype]
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct cxgbi_ppm_pool *pools @@ got void [noderef] __percpu * @@
expected struct cxgbi_ppm_pool *pools
sparse: got void [noderef] __percpu *
sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct cxgbi_ppm_pool * @@
sparse: expected void const [noderef] __percpu *__vpp_verify
got struct cxgbi_ppm_pool *
sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct cxgbi_ppm_pool [noderef] __percpu *pool @@ got struct cxgbi_ppm_pool *[assigned] pool @@
sparse: expected struct cxgbi_ppm_pool [noderef] __percpu *pool
got struct cxgbi_ppm_pool *[assigned] pool
sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __percpu *__pdata @@ got struct cxgbi_ppm_pool *[assigned] pool @@
sparse: expected void [noderef] __percpu *__pdata
got struct cxgbi_ppm_pool *[assigned] pool
r> Varun Prakash 2016-02-14 291
Varun Prakash 2016-02-14 292 void cxgbi_ppm_make_ppod_hdr(struct cxgbi_ppm *ppm, u32 tag,
Varun Prakash 2016-02-14 293 unsigned int tid, unsigned int offset,
Varun Prakash 2016-02-14 294 unsigned int length,
Varun Prakash 2016-02-14 295 struct cxgbi_pagepod_hdr *hdr)
Varun Prakash 2016-02-14 296 {
Varun Prakash 2016-02-14 297 /* The ddp tag in pagepod should be with bit 31:30 set to 0.
Varun Prakash 2016-02-14 298 * The ddp Tag on the wire should be with non-zero 31:30 to the peer
Varun Prakash 2016-02-14 299 */
Varun Prakash 2016-02-14 300 tag &= 0x3FFFFFFF;
Varun Prakash 2016-02-14 301
Varun Prakash 2016-02-14 302 hdr->vld_tid = htonl(PPOD_VALID_FLAG | PPOD_TID(tid));
Varun Prakash 2016-02-14 303
Varun Prakash 2016-02-14 304 hdr->rsvd = 0;
Varun Prakash 2016-02-14 @305 hdr->pgsz_tag_clr = htonl(tag & ppm->tformat.idx_clr_mask);
Varun Prakash 2016-02-14 @306 hdr->max_offset = htonl(length);
Varun Prakash 2016-02-14 @307 hdr->page_offset = htonl(offset);
Varun Prakash 2016-02-14 308
Varun Prakash 2016-02-14 309 pr_debug("ippm: tag 0x%x, tid 0x%x, xfer %u, off %u.\n",
Varun Prakash 2016-02-14 310 tag, tid, length, offset);
Varun Prakash 2016-02-14 311 }
Varun Prakash 2016-02-14 312 EXPORT_SYMBOL(cxgbi_ppm_make_ppod_hdr);
Varun Prakash 2016-02-14 313
Varun Prakash 2016-02-14 314 static void ppm_free(struct cxgbi_ppm *ppm)
Varun Prakash 2016-02-14 315 {
Varun Prakash 2016-02-14 316 vfree(ppm);
Varun Prakash 2016-02-14 317 }
Varun Prakash 2016-02-14 318
Varun Prakash 2016-02-14 319 static void ppm_destroy(struct kref *kref)
Varun Prakash 2016-02-14 320 {
Varun Prakash 2016-02-14 321 struct cxgbi_ppm *ppm = container_of(kref,
Varun Prakash 2016-02-14 322 struct cxgbi_ppm,
Varun Prakash 2016-02-14 323 refcnt);
Varun Prakash 2016-02-14 324 pr_info("ippm: kref 0, destroy %s ppm 0x%p.\n",
Varun Prakash 2016-02-14 325 ppm->ndev->name, ppm);
Varun Prakash 2016-02-14 326
Varun Prakash 2016-02-14 327 *ppm->ppm_pp = NULL;
Varun Prakash 2016-02-14 328
Varun Prakash 2016-02-14 329 free_percpu(ppm->pool);
Varun Prakash 2016-02-14 330 ppm_free(ppm);
Varun Prakash 2016-02-14 331 }
Varun Prakash 2016-02-14 332
Varun Prakash 2016-02-14 333 int cxgbi_ppm_release(struct cxgbi_ppm *ppm)
Varun Prakash 2016-02-14 334 {
Varun Prakash 2016-02-14 335 if (ppm) {
Varun Prakash 2016-02-14 336 int rv;
Varun Prakash 2016-02-14 337
Varun Prakash 2016-02-14 338 rv = kref_put(&ppm->refcnt, ppm_destroy);
Varun Prakash 2016-02-14 339 return rv;
Varun Prakash 2016-02-14 340 }
Varun Prakash 2016-02-14 341 return 1;
Varun Prakash 2016-02-14 342 }
Varun Prakash 2016-07-21 343 EXPORT_SYMBOL(cxgbi_ppm_release);
Varun Prakash 2016-02-14 344
Varun Prakash 2016-02-14 345 static struct cxgbi_ppm_pool *ppm_alloc_cpu_pool(unsigned int *total,
Varun Prakash 2016-02-14 346 unsigned int *pcpu_ppmax)
Varun Prakash 2016-02-14 347 {
Varun Prakash 2016-02-14 348 struct cxgbi_ppm_pool *pools;
Varun Prakash 2016-02-14 349 unsigned int ppmax = (*total) / num_possible_cpus();
Varun Prakash 2016-02-14 350 unsigned int max = (PCPU_MIN_UNIT_SIZE - sizeof(*pools)) << 3;
Varun Prakash 2016-02-14 351 unsigned int bmap;
Varun Prakash 2016-02-14 352 unsigned int alloc_sz;
Varun Prakash 2016-02-14 353 unsigned int count = 0;
Varun Prakash 2016-02-14 354 unsigned int cpu;
Varun Prakash 2016-02-14 355
Varun Prakash 2016-02-14 356 /* make sure per cpu pool fits into PCPU_MIN_UNIT_SIZE */
Varun Prakash 2016-02-14 357 if (ppmax > max)
Varun Prakash 2016-02-14 358 ppmax = max;
Varun Prakash 2016-02-14 359
Varun Prakash 2016-02-14 360 /* pool size must be multiple of unsigned long */
Varun Prakash 2019-04-03 361 bmap = ppmax / BITS_PER_TYPE(unsigned long);
Varun Prakash 2019-04-03 362 if (!bmap)
Varun Prakash 2019-04-03 363 return NULL;
Varun Prakash 2019-04-03 364
Varun Prakash 2016-02-14 365 ppmax = (bmap * sizeof(unsigned long)) << 3;
Varun Prakash 2016-02-14 366
Varun Prakash 2016-02-14 367 alloc_sz = sizeof(*pools) + sizeof(unsigned long) * bmap;
Varun Prakash 2016-02-14 @368 pools = __alloc_percpu(alloc_sz, __alignof__(struct cxgbi_ppm_pool));
Varun Prakash 2016-02-14 369
Varun Prakash 2016-02-14 370 if (!pools)
Varun Prakash 2016-02-14 371 return NULL;
Varun Prakash 2016-02-14 372
Varun Prakash 2016-02-14 373 for_each_possible_cpu(cpu) {
Varun Prakash 2016-02-14 @374 struct cxgbi_ppm_pool *ppool = per_cpu_ptr(pools, cpu);
Varun Prakash 2016-02-14 375
Varun Prakash 2016-02-14 376 memset(ppool, 0, alloc_sz);
Varun Prakash 2016-02-14 377 spin_lock_init(&ppool->lock);
Varun Prakash 2016-02-14 378 count += ppmax;
Varun Prakash 2016-02-14 379 }
Varun Prakash 2016-02-14 380
Varun Prakash 2016-02-14 381 *total = count;
Varun Prakash 2016-02-14 382 *pcpu_ppmax = ppmax;
Varun Prakash 2016-02-14 383
Varun Prakash 2016-02-14 384 return pools;
Varun Prakash 2016-02-14 385 }
Varun Prakash 2016-02-14 386
Varun Prakash 2016-02-14 387 int cxgbi_ppm_init(void **ppm_pp, struct net_device *ndev,
Varun Prakash 2016-02-14 388 struct pci_dev *pdev, void *lldev,
Varun Prakash 2019-06-10 389 struct cxgbi_tag_format *tformat, unsigned int iscsi_size,
Varun Prakash 2019-06-10 390 unsigned int llimit, unsigned int start,
Varun Prakash 2019-06-10 391 unsigned int reserve_factor, unsigned int iscsi_edram_start,
Varun Prakash 2019-06-10 392 unsigned int iscsi_edram_size)
Varun Prakash 2016-02-14 393 {
Varun Prakash 2016-02-14 394 struct cxgbi_ppm *ppm = (struct cxgbi_ppm *)(*ppm_pp);
Varun Prakash 2016-02-14 395 struct cxgbi_ppm_pool *pool = NULL;
Varun Prakash 2016-02-14 396 unsigned int pool_index_max = 0;
Varun Prakash 2019-06-10 397 unsigned int ppmax_pool = 0;
Varun Prakash 2016-02-14 398 unsigned int ppod_bmap_size;
Varun Prakash 2019-06-10 399 unsigned int alloc_sz;
Varun Prakash 2019-06-10 400 unsigned int ppmax;
Varun Prakash 2019-06-10 401
Varun Prakash 2019-06-10 402 if (!iscsi_edram_start)
Varun Prakash 2019-06-10 403 iscsi_edram_size = 0;
Varun Prakash 2019-06-10 404
Varun Prakash 2019-06-10 405 if (iscsi_edram_size &&
Varun Prakash 2019-06-10 406 ((iscsi_edram_start + iscsi_edram_size) != start)) {
Varun Prakash 2019-06-10 407 pr_err("iscsi ppod region not contiguous: EDRAM start 0x%x "
Varun Prakash 2019-06-10 408 "size 0x%x DDR start 0x%x\n",
Varun Prakash 2019-06-10 409 iscsi_edram_start, iscsi_edram_size, start);
Varun Prakash 2019-06-10 410 return -EINVAL;
Varun Prakash 2019-06-10 411 }
Varun Prakash 2019-06-10 412
Varun Prakash 2019-06-10 413 if (iscsi_edram_size) {
Varun Prakash 2019-06-10 414 reserve_factor = 0;
Varun Prakash 2019-06-10 415 start = iscsi_edram_start;
Varun Prakash 2019-06-10 416 }
Varun Prakash 2019-06-10 417
Varun Prakash 2019-06-10 418 ppmax = (iscsi_edram_size + iscsi_size) >> PPOD_SIZE_SHIFT;
Varun Prakash 2016-02-14 419
Varun Prakash 2016-02-14 420 if (ppm) {
Varun Prakash 2016-02-14 421 pr_info("ippm: %s, ppm 0x%p,0x%p already initialized, %u/%u.\n",
Varun Prakash 2016-02-14 422 ndev->name, ppm_pp, ppm, ppm->ppmax, ppmax);
Varun Prakash 2016-02-14 423 kref_get(&ppm->refcnt);
Varun Prakash 2016-02-14 424 return 1;
Varun Prakash 2016-02-14 425 }
Varun Prakash 2016-02-14 426
Varun Prakash 2016-02-14 427 if (reserve_factor) {
Varun Prakash 2016-02-14 428 ppmax_pool = ppmax / reserve_factor;
Varun Prakash 2016-02-14 429 pool = ppm_alloc_cpu_pool(&ppmax_pool, &pool_index_max);
Varun Prakash 2019-04-03 430 if (!pool) {
Varun Prakash 2019-04-03 431 ppmax_pool = 0;
Varun Prakash 2019-04-03 432 reserve_factor = 0;
Varun Prakash 2019-04-03 433 }
Varun Prakash 2016-02-14 434
Varun Prakash 2016-02-14 435 pr_debug("%s: ppmax %u, cpu total %u, per cpu %u.\n",
Varun Prakash 2016-02-14 436 ndev->name, ppmax, ppmax_pool, pool_index_max);
Varun Prakash 2016-02-14 437 }
Varun Prakash 2016-02-14 438
Varun Prakash 2016-02-14 439 ppod_bmap_size = BITS_TO_LONGS(ppmax - ppmax_pool);
Varun Prakash 2016-02-14 440 alloc_sz = sizeof(struct cxgbi_ppm) +
Varun Prakash 2016-02-14 441 ppmax * (sizeof(struct cxgbi_ppod_data)) +
Varun Prakash 2016-02-14 442 ppod_bmap_size * sizeof(unsigned long);
Varun Prakash 2016-02-14 443
YueHaibing 2018-07-19 444 ppm = vzalloc(alloc_sz);
Varun Prakash 2016-02-14 445 if (!ppm)
Varun Prakash 2016-02-14 446 goto release_ppm_pool;
Varun Prakash 2016-02-14 447
Varun Prakash 2016-02-14 448 ppm->ppod_bmap = (unsigned long *)(&ppm->ppod_data[ppmax]);
Varun Prakash 2016-02-14 449
Varun Prakash 2016-02-14 450 if ((ppod_bmap_size >> 3) > (ppmax - ppmax_pool)) {
Varun Prakash 2016-02-14 451 unsigned int start = ppmax - ppmax_pool;
Varun Prakash 2016-02-14 452 unsigned int end = ppod_bmap_size >> 3;
Varun Prakash 2016-02-14 453
Varun Prakash 2016-02-14 454 bitmap_set(ppm->ppod_bmap, ppmax, end - start);
Varun Prakash 2016-02-14 455 pr_info("%s: %u - %u < %u * 8, mask extra bits %u, %u.\n",
Varun Prakash 2016-02-14 456 __func__, ppmax, ppmax_pool, ppod_bmap_size, start,
Varun Prakash 2016-02-14 457 end);
Varun Prakash 2016-02-14 458 }
Varun Prakash 2019-06-10 459 if (iscsi_edram_size) {
Varun Prakash 2019-06-10 460 unsigned int first_ddr_idx =
Varun Prakash 2019-06-10 461 iscsi_edram_size >> PPOD_SIZE_SHIFT;
Varun Prakash 2019-06-10 462
Varun Prakash 2019-06-10 463 ppm->max_index_in_edram = first_ddr_idx - 1;
Varun Prakash 2019-06-10 464 bitmap_set(ppm->ppod_bmap, first_ddr_idx, 1);
Varun Prakash 2019-06-10 465 pr_debug("reserved %u ppod in bitmap\n", first_ddr_idx);
Varun Prakash 2019-06-10 466 }
Varun Prakash 2016-02-14 467
Varun Prakash 2016-02-14 468 spin_lock_init(&ppm->map_lock);
Varun Prakash 2016-02-14 469 kref_init(&ppm->refcnt);
Varun Prakash 2016-02-14 470
Varun Prakash 2016-02-14 471 memcpy(&ppm->tformat, tformat, sizeof(struct cxgbi_tag_format));
Varun Prakash 2016-02-14 472
Varun Prakash 2016-02-14 473 ppm->ppm_pp = ppm_pp;
Varun Prakash 2016-02-14 474 ppm->ndev = ndev;
Varun Prakash 2016-02-14 475 ppm->pdev = pdev;
Varun Prakash 2016-02-14 476 ppm->lldev = lldev;
Varun Prakash 2016-02-14 477 ppm->ppmax = ppmax;
Varun Prakash 2016-02-14 478 ppm->next = 0;
Varun Prakash 2016-02-14 479 ppm->llimit = llimit;
Varun Prakash 2016-02-14 480 ppm->base_idx = start > llimit ?
Varun Prakash 2016-02-14 481 (start - llimit + 1) >> PPOD_SIZE_SHIFT : 0;
Varun Prakash 2016-02-14 482 ppm->bmap_index_max = ppmax - ppmax_pool;
Varun Prakash 2016-02-14 483
Varun Prakash 2016-02-14 @484 ppm->pool = pool;
Varun Prakash 2016-02-14 485 ppm->pool_rsvd = ppmax_pool;
Varun Prakash 2016-02-14 486 ppm->pool_index_max = pool_index_max;
Varun Prakash 2016-02-14 487
Varun Prakash 2016-02-14 488 /* check one more time */
Varun Prakash 2016-02-14 489 if (*ppm_pp) {
Varun Prakash 2016-02-14 490 ppm_free(ppm);
Varun Prakash 2016-02-14 491 ppm = (struct cxgbi_ppm *)(*ppm_pp);
Varun Prakash 2016-02-14 492
Varun Prakash 2016-02-14 493 pr_info("ippm: %s, ppm 0x%p,0x%p already initialized, %u/%u.\n",
Varun Prakash 2016-02-14 494 ndev->name, ppm_pp, *ppm_pp, ppm->ppmax, ppmax);
Varun Prakash 2016-02-14 495
Varun Prakash 2016-02-14 496 kref_get(&ppm->refcnt);
Varun Prakash 2016-02-14 497 return 1;
Varun Prakash 2016-02-14 498 }
Varun Prakash 2016-02-14 499 *ppm_pp = ppm;
Varun Prakash 2016-02-14 500
Varun Prakash 2016-02-14 501 ppm->tformat.pgsz_idx_dflt = cxgbi_ppm_find_page_index(ppm, PAGE_SIZE);
Varun Prakash 2016-02-14 502
Varun Prakash 2016-02-14 503 pr_info("ippm %s: ppm 0x%p, 0x%p, base %u/%u, pg %lu,%u, rsvd %u,%u.\n",
Varun Prakash 2016-02-14 504 ndev->name, ppm_pp, ppm, ppm->base_idx, ppm->ppmax, PAGE_SIZE,
Varun Prakash 2016-02-14 505 ppm->tformat.pgsz_idx_dflt, ppm->pool_rsvd,
Varun Prakash 2016-02-14 506 ppm->pool_index_max);
Varun Prakash 2016-02-14 507
Varun Prakash 2016-02-14 508 return 0;
Varun Prakash 2016-02-14 509
Varun Prakash 2016-02-14 510 release_ppm_pool:
Varun Prakash 2016-02-14 @511 free_percpu(pool);
Varun Prakash 2016-02-14 512 return -ENOMEM;
Varun Prakash 2016-02-14 513 }
Varun Prakash 2016-02-14 514 EXPORT_SYMBOL(cxgbi_ppm_init);
Varun Prakash 2016-02-14 515
commit
add iSCSI DDP page pod manager
/kbuild-all@xxxxxxxxxxxx">https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
br>

Next message: Sami Tolvanen: "[PATCH 07/22] kbuild: lto: merge module sections"
Previous message: Marcelo Ricardo Leitner: "[PATCH net] sctp: Don't advertise IPv4 addresses if ipv6only is set on the socket"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]