Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes

From: David Miller
Date: Wed Jun 24 2020 - 17:48:13 EST


From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>
Date: Wed, 24 Jun 2020 09:00:44 +0200

> In mvneta_config_interface() the RGMII modes are catched by the default
> case which is an error return. The RGMII modes are valid modes for the
> driver, so instead of returning an error add a break statement to return
> successfully.
>
> This avoids this warning for non comphy SoCs which use RGMII, like
> SolidRun Clearfog:
>
> WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c
>
> Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx>

Applied.