Re: [PATCH 06/11] phy: un-inline devm_mdiobus_register()
From: Bartosz Golaszewski
Date: Thu Jun 25 2020 - 05:16:18 EST
On Tue, Jun 23, 2020 at 1:55 AM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
>
> On 6/22/20 3:00 AM, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> >
> > Functions should only be static inline if they're very short. This
> > devres helper is already over 10 lines and it will grow soon as we'll
> > be improving upon its approach. Pull it into mdio_devres.c.
> >
> > Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> > ---
> > drivers/net/phy/Makefile | 2 +-
> > drivers/net/phy/mdio_devres.c | 18 ++++++++++++++++++
> > include/linux/phy.h | 15 ++-------------
> > 3 files changed, 21 insertions(+), 14 deletions(-)
> > create mode 100644 drivers/net/phy/mdio_devres.c
>
> This would likely require an update to the MAINTAINERS file for this new
> file to be picked up by the correct entry.
It's already included in drivers/net/phy/ in the ETHERNET PHY LIBRARY entry.
Bartosz