Re: [PATCH v2 1/2] gpio: add GPO driver for PCA9570

[kernel test robot]

Hi Sungbo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[also build test ERROR on v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Sungbo-Eo/gpio-add-GPO-driver-for-PCA9570/20200625-160356
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8911a35180c6777188fefe0954a2451a2b91deaf)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/gpio/gpio-pca9570.c:141:12: error: use of undeclared identifier 'pca9570_remove'; did you mean 'pca9570_probe'?
           .remove = pca9570_remove,
                     ^~~~~~~~~~~~~~
                     pca9570_probe
   drivers/gpio/gpio-pca9570.c:101:12: note: 'pca9570_probe' declared here
   static int pca9570_probe(struct i2c_client *client,
              ^
>> drivers/gpio/gpio-pca9570.c:141:12: error: incompatible function pointer types initializing 'int (*)(struct i2c_client *)' with an expression of type 'int (struct i2c_client *, const struct i2c_device_id *)' [-Werror,-Wincompatible-function-pointer-types]
           .remove = pca9570_remove,
                     ^~~~~~~~~~~~~~
   2 errors generated.

vim +141 drivers/gpio/gpio-pca9570.c

   134	
   135	static struct i2c_driver pca9570_driver = {
   136		.driver = {
   137			.name = "pca9570",
   138			.of_match_table = pca9570_of_match_table,
   139		},
   140		.probe = pca9570_probe,
 > 141		.remove = pca9570_remove,
   142		.id_table = pca9570_id_table,
   143	};
   144	module_i2c_driver(pca9570_driver);
   145	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip