Re: [PATCH 4.19 012/206] ALSA: hda/realtek - Introduce polarity for micmute LED GPIO

From: Pavel Machek
Date: Thu Jun 25 2020 - 15:03:00 EST


Hi!

> Currently mute LED and micmute LED share the same GPIO polarity.
>
> So split the polarity for mute and micmute, in case they have different
> polarities.

> +++ b/sound/pci/hda/patch_realtek.c
> @@ -94,6 +94,7 @@ struct alc_spec {
>
> /* mute LED for HP laptops, see alc269_fixup_mic_mute_hook() */
> int mute_led_polarity;
> + int micmute_led_polarity;
> hda_nid_t mute_led_nid;
> hda_nid_t cap_mute_led_nid;
>

This variable will be always zero in 4.19.130... so the patch does not
really do anything.

In mainline, commit 3e0650ab26e20 makes use of this variable.

Best regards,
Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: PGP signature