Re: [PATCH][V2] qed: add missing error test for DBG_STATUS_NO_MATCHING_FRAMING_MODE
From: David Miller
Date: Thu Jun 25 2020 - 15:48:39 EST
From: Colin King <colin.king@xxxxxxxxxxxxx>
Date: Thu, 25 Jun 2020 17:45:05 +0100
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> The error DBG_STATUS_NO_MATCHING_FRAMING_MODE was added to the enum
> enum dbg_status however there is a missing corresponding entry for
> this in the array s_status_str. This causes an out-of-bounds read when
> indexing into the last entry of s_status_str. Fix this by adding in
> the missing entry.
>
> Addresses-Coverity: ("Out-of-bounds read").
> Fixes: 2d22bc8354b1 ("qed: FW 8.42.2.0 debug features")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>
> V2: use the error message as suggested by Igor Russkikh
I already applied your V1 so this patch no longer applies.