Re: [PATCH v2] tpm_tis: Remove the HID IFX0102

From: Jerry Snitselaar
Date: Thu Jun 25 2020 - 17:19:39 EST


On Fri Jun 26 20, Jarkko Sakkinen wrote:
On Wed, Jun 24, 2020 at 11:21:50PM -0700, Jerry Snitselaar wrote:
On Thu Jun 25 20, Jarkko Sakkinen wrote:
> Acer C720 running Linux v5.3 reports this in klog:
>
> tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16)
> tpm tpm0: tpm_try_transmit: send(): error -5
> tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> tpm_tis tpm_tis: Could not get TPM timeouts and durations
> tpm_tis 00:08: 1.2 TPM (device-id 0xB, rev-id 16)
> tpm tpm0: tpm_try_transmit: send(): error -5
> tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts
> tpm_tis 00:08: Could not get TPM timeouts and durations
> ima: No TPM chip found, activating TPM-bypass!
> tpm_inf_pnp 00:08: Found TPM with ID IFX0102
>
> % git --no-pager grep IFX0102 drivers/char/tpm
> drivers/char/tpm/tpm_infineon.c: {"IFX0102", 0},
> drivers/char/tpm/tpm_tis.c: {"IFX0102", 0}, /* Infineon */
>
> Obviously IFX0102 was added to the HID table for the TCG TIS driver by
> mistake.
>
> Fixes: 93e1b7d42e1e ("[PATCH] tpm: add HID module parameter")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=203877
> Cc: Kylene Jo Hall <kjhall@xxxxxxxxxx>
> Reported-by: Ferry Toth: <ferry.toth@xxxxxxxxxxxx>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx>

Reviewed-by: Jerry Snitselaar <jsnitsel@xxxxxxxxxx>

Bugzilla has an example of similar behavior with v4.15. I'll apply this
asap.

/Jarkko


Any idea what happened to git.infradead.org? It was offline the other day,
and at the moment not all repos from before seem to be there.