RE: [EXT] [PATCH v1] bnx2x: use generic power management

[Sudarsana Reddy Kalluru]

> -----Original Message-----
> From: Igor Russkikh <irusskikh@xxxxxxxxxxx>
> Sent: Thursday, June 25, 2020 10:16 PM
> To: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>; Bjorn Helgaas
> <helgaas@xxxxxxxxxx>; Bjorn Helgaas <bhelgaas@xxxxxxxxxx>;
> bjorn@xxxxxxxxxxx; Vaibhav Gupta <vaibhav.varodek@xxxxxxxxx>; David S.
> Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Ariel Elior
> <aelior@xxxxxxxxxxx>; Sudarsana Reddy Kalluru <skalluru@xxxxxxxxxxx>; GR-
> everest-linux-l2 <GR-everest-linux-l2@xxxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-kernel-
> mentees@xxxxxxxxxxxxxxxxxxxxxxxxx; skhan@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [EXT] [PATCH v1] bnx2x: use generic power management
> 
> 
> 
> On 24/06/2020 8:51 pm, Vaibhav Gupta wrote:
> > External Email
> >
> > ----------------------------------------------------------------------
> > With legacy PM, drivers themselves were responsible for managing the
> > device's power states and takes care of register states.
> >
> > After upgrading to the generic structure, PCI core will take care of
> > required tasks and drivers should do only device-specific operations.
> >
> > The driver was also calling bnx2x_set_power_state() to set the power
> > state of the device by changing the device's registers' value. It is
> > no more needed.
> >
> > Compile-tested only.
> >
> > Signed-off-by: Vaibhav Gupta <vaibhavgupta40@xxxxxxxxx>
> > ---
> >  drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c  | 15 ++++++---------
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h  |  4 +---
> > drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |  3 +--
> >  3 files changed, 8 insertions(+), 14 deletions(-)
> 
> Acked-by: Igor Russkikh <irusskikh@xxxxxxxxxxx>
> 
> Sudarsana, could you please give it a short sanity test and report back?
> 
> Thanks,
>   Igor

I have run the basic sanity test with these changes in the driver, didnât see any issues.

Thanks,
Sudarsana