Re: [PATCH V4 3/7] phy: tegra: xusb: Add USB2 pad power control support for Tegra210

[kernel test robot]

Hi Nagarjuna,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on tegra/for-next]
[also build test WARNING on robh/for-next v5.8-rc2 next-20200626]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nagarjuna-Kristam/Tegra-XUSB-charger-detect-support/20200626-182459
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> drivers/phy/tegra/xusb-tegra210.c:1055:6: warning: no previous prototype for 'tegra210_usb2_pad_power_on' [-Wmissing-prototypes]
    1055 | void tegra210_usb2_pad_power_on(struct phy *phy)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/phy/tegra/xusb-tegra210.c:1088:6: warning: no previous prototype for 'tegra210_usb2_pad_power_down' [-Wmissing-prototypes]
    1088 | void tegra210_usb2_pad_power_down(struct phy *phy)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/tegra210_usb2_pad_power_on +1055 drivers/phy/tegra/xusb-tegra210.c

  1053	
  1054	/* must be called under padctl->lock */
> 1055	void tegra210_usb2_pad_power_on(struct phy *phy)
  1056	{
  1057		struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
  1058		struct tegra_xusb_usb2_lane *usb2 = to_usb2_lane(lane);
  1059		struct tegra_xusb_usb2_pad *pad = to_usb2_pad(lane->pad);
  1060		struct tegra_xusb_padctl *padctl = lane->pad->padctl;
  1061		unsigned int index = lane->index;
  1062		u32 value;
  1063	
  1064		if (!phy)
  1065			return;
  1066	
  1067		if (usb2->powered_on)
  1068			return;
  1069	
  1070		dev_info(padctl->dev, "power on UTMI pads %d\n", index);
  1071	
  1072		tegra210_usb2_bias_pad_power_on(pad);
  1073	
  1074		udelay(2);
  1075	
  1076		value = padctl_readl(padctl, XUSB_PADCTL_USB2_OTG_PADX_CTL0(index));
  1077		value &= ~XUSB_PADCTL_USB2_OTG_PAD_CTL0_PD;
  1078		padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL0(index));
  1079	
  1080		value = padctl_readl(padctl, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
  1081		value &= ~XUSB_PADCTL_USB2_OTG_PAD_CTL1_PD_DR;
  1082		padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
  1083	
  1084		usb2->powered_on = true;
  1085	}
  1086	
  1087	/* must be called under padctl->lock */
> 1088	void tegra210_usb2_pad_power_down(struct phy *phy)
  1089	{
  1090		struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
  1091		struct tegra_xusb_usb2_lane *usb2 = to_usb2_lane(lane);
  1092		struct tegra_xusb_usb2_pad *pad = to_usb2_pad(lane->pad);
  1093		struct tegra_xusb_padctl *padctl = lane->pad->padctl;
  1094		unsigned int index = lane->index;
  1095		u32 value;
  1096	
  1097		if (!phy)
  1098			return;
  1099	
  1100		if (!usb2->powered_on)
  1101			return;
  1102	
  1103		dev_info(padctl->dev, "power down UTMI pad %d\n", index);
  1104	
  1105		value = padctl_readl(padctl, XUSB_PADCTL_USB2_OTG_PADX_CTL0(index));
  1106		value |= XUSB_PADCTL_USB2_OTG_PAD_CTL0_PD;
  1107		padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL0(index));
  1108	
  1109		value = padctl_readl(padctl, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
  1110		value |= XUSB_PADCTL_USB2_OTG_PAD_CTL1_PD_DR;
  1111		padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
  1112	
  1113		udelay(2);
  1114	
  1115		tegra210_usb2_bias_pad_power_off(pad);
  1116		usb2->powered_on = false;
  1117	}
  1118	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip