Re: [PATCH] staging: media: usbvision: removing prohibited space before ',' (ctx:WxW)

[Hans Verkuil]

On 26/06/2020 16:32, B K Karthik wrote:
> fixing ERROR: space prohibited before that ',' (ctx:WxW)
> 
> Signed-off-by: B K Karthik <karthik.bk2000@xxxxxxxx>

usbvision is another driver that is scheduled for removal by the end of the year,
so I won't apply this patch.

> ---
>  drivers/staging/media/usbvision/usbvision-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/media/usbvision/usbvision-i2c.c b/drivers/staging/media/usbvision/usbvision-i2c.c
> index 6e4df3335b1b..010ad03c6ec1 100644
> --- a/drivers/staging/media/usbvision/usbvision-i2c.c
> +++ b/drivers/staging/media/usbvision/usbvision-i2c.c
> @@ -32,7 +32,7 @@ MODULE_PARM_DESC(i2c_debug, "enable debug messages [i2c]");
>  #define PDEBUG(level, fmt, args...) { \
>  		if (i2c_debug & (level)) \
>  			printk(KERN_INFO KBUILD_MODNAME ":[%s:%d] " fmt, \
> -				__func__, __LINE__ , ## args); \
> +				__func__, __LINE__, ## args); \

Actually, older (buggy) gcc compiler needed a space there, if memory serves.

Regards,

	Hans

>  	}
>  
>  static int usbvision_i2c_write(struct usb_usbvision *usbvision, unsigned char addr, char *buf,
>