Re: [PATCH 07/10] misc: mic: vop: vop_main: Remove set but unused variable 'ret'

[Arnd Bergmann]

On Fri, Jun 26, 2020 at 3:05 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> Hasn't been checked since its conception 2 years ago.
>
> Squashes W=1 warning:
>
>  drivers/misc/mic/vop/vop_main.c: In function â_vop_scan_devicesâ:
>  drivers/misc/mic/vop/vop_main.c:617:6: warning: variable âretâ set but not used [-Wunused-but-set-variable]
>  617 | int ret;
>  | ^~~
>
> Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> Cc: Ashutosh Dixit <ashutosh.dixit@xxxxxxxxx>
> Cc: Christian Borntraeger <borntraeger@xxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

This is a correct change, but I'd take it one step further and make the
_vop_remove_device() function return 'void' if you don't mind
respinning the patch.

Either way

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>