Re: [PATCH 04/10] misc: lkdtm: bugs: At least try to use popuated variable

[Kees Cook]

On Fri, Jun 26, 2020 at 02:05:19PM +0100, Lee Jones wrote:
> The result may not be intereresting, but not using a set variable
> is bad form and causes W=1 kernel builds to complain.
> 
> Fixes the following W=1 warning(s):
> 
>  drivers/misc/lkdtm/bugs.c: In function âlkdtm_STACK_GUARD_PAGE_LEADINGâ:
>  drivers/misc/lkdtm/bugs.c:331:25: warning: variable âbyteâ set but not used [-Wunused-but-set-variable]
>  331 | volatile unsigned char byte;
>  | ^~~~
>  drivers/misc/lkdtm/bugs.c: In function âlkdtm_STACK_GUARD_PAGE_TRAILINGâ:
>  drivers/misc/lkdtm/bugs.c:345:25: warning: variable âbyteâ set but not used [-Wunused-but-set-variable]
>  345 | volatile unsigned char byte;
>  | ^~~~
> 
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx>

Ah yeah, this looks like a reasonable way to deal with it. Thanks!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>

-- 
Kees Cook